systemservices/marketplace: manifest validation #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilgooz
force-pushed
the
ss-marketplace/feature/manifest-validation
branch
from
e4480c6
to
35ff845
Compare
ilgooz
force-pushed
the
ss-marketplace/feature/manifest-validation
branch
3 times, most recently
from
2ca13c3
to
47d6a3f
Compare
|
Just seeing this PR I was thinking why not delegating more to the system service and have the publish command that actually take the content of the manifest in the |
ilgooz
force-pushed
the
ss-marketplace/feature/manifest-validation
branch
from
47d6a3f
to
7d12df8
Compare
NicolasMahe
reviewed
Mar 20, 2019
NicolasMahe
reviewed
Mar 20, 2019
ilgooz
force-pushed
the
ss-marketplace/feature/manifest-validation
branch
2 times, most recently
from
77ed536
to
70ada3e
Compare
NicolasMahe
requested changes
Mar 21, 2019
manifest data is created by users/devs. thus, its content is not trusted and it needs to be validated. this way, it's possible to ignore any service versions that have invalid manifest data. the validation made with JSON Schemas, one created from Manifest TS type and other created manually for service's definition. * added gen-schema command to package.json to generate JSON Schema of Manitest type. * added package-lock.json file.
ilgooz
force-pushed
the
ss-marketplace/feature/manifest-validation
branch
from
5146c90
to
ea6f8ec
Compare
This was referenced Mar 24, 2019
NicolasMahe
requested changes
Mar 27, 2019
antho1404
reviewed
Mar 27, 2019
antho1404
reviewed
Mar 28, 2019
NicolasMahe
previously approved these changes
Mar 28, 2019
…github.com/mesg-foundation/core into ss-marketplace/feature/manifest-validation
NicolasMahe
previously approved these changes
Mar 29, 2019
…tplace/feature/manifest-validation # Conflicts: # systemservices/marketplace/package-lock.json # systemservices/marketplace/package.json
antho1404
approved these changes
Mar 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
manifest data is created by users/devs. thus, its content is not trusted and it needs to be validated. this way, it's possible to ignore any service versions that have invalid manifest data.