api: simplify the code & switch to container mocks for testing #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactored to simplify the code. * improved testing helpers. * improved some tests by testing public funcs instead of the inner(private) implementations. we were going to do this improvement at some point but wasn't the subject of this commit. it's started here now to keep the tests of the removed private funcs. this improvement will be applied to the rest of the existing tests later. * use container mocks instead of dockertest for testing. * removed unnecessary tests: TestCheckService, TestCreateTempFolder, TestRemoveTempFolder. * improved some comments.
ilgooz
force-pushed
the
feature/simplify-api
branch
from
3b64922
to
9c1b56f
Compare
moved contents of small files to api.go & api_test.go.
ilgooz
force-pushed
the
feature/simplify-api
branch
from
9c1b56f
to
f90f96d
Compare
antho1404
reviewed
Apr 2, 2019
antho1404
reviewed
Apr 2, 2019
ilgooz
force-pushed
the
feature/simplify-api
branch
from
9dc7fca
to
647cb91
Compare
* cosmetic updates * improved docs
ilgooz
force-pushed
the
feature/simplify-api
branch
from
647cb91
to
7cece59
Compare
antho1404
approved these changes
Apr 2, 2019
NicolasMahe
approved these changes
Apr 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
similar to #799 about the refactoring of api pkg.
please review each commit individually.