moved service deployment logic from service pkg to api pkg #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to make reviewing easier for the next commit.
ilgooz
force-pushed
the
refactoring/move-deploy-to-api
branch
from
f7375fc
to
e97ff69
Compare
Service type will be simplifed by moving its methods to the container Manager that will be introduced in future. Manager will be about managing the containers related to service. thus, it cannot have logic related to building a Docker image (service deployment) and service pkg cannot keep this logic as well. as a result, this logic is moved to the api pkg.
ilgooz
force-pushed
the
refactoring/move-deploy-to-api
branch
from
e97ff69
to
c28caea
Compare
krhubert
previously approved these changes
Apr 12, 2019
antho1404
requested changes
Apr 13, 2019
ilgooz
force-pushed
the
refactoring/move-deploy-to-api
branch
3 times, most recently
from
ad8066f
to
48c88a4
Compare
ilgooz
force-pushed
the
refactoring/move-deploy-to-api
branch
from
48c88a4
to
a6d7a4a
Compare
krhubert
approved these changes
Apr 15, 2019
antho1404
approved these changes
Apr 17, 2019
NicolasMahe
approved these changes
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there are no logical changes made on code