Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service: simplify DeleteVolumes() #881

Merged
merged 4 commits into from
Apr 17, 2019

Conversation

ilgooz
Copy link
Contributor

@ilgooz ilgooz commented Apr 16, 2019

related to service refactoring #799

@ilgooz ilgooz requested a review from a team April 16, 2019 09:56
@ilgooz ilgooz force-pushed the refactoring/service/simplify-deleteVolumes branch 2 times, most recently from 806379c to 6be4e75 Compare April 16, 2019 10:59
@ilgooz ilgooz added the wip label Apr 16, 2019
@ilgooz ilgooz force-pushed the refactoring/service/simplify-deleteVolumes branch from 6be4e75 to 00d8f65 Compare April 16, 2019 13:07
* moved Dependency.DeleteVolumes() logic into Service.DeleteVolumes().
@ilgooz ilgooz force-pushed the refactoring/service/simplify-deleteVolumes branch from 00d8f65 to ff141a4 Compare April 16, 2019 13:21
@ilgooz ilgooz removed the wip label Apr 16, 2019
@ilgooz ilgooz requested a review from NicolasMahe April 17, 2019 07:44
@NicolasMahe NicolasMahe merged commit 2ebfd6c into dev Apr 17, 2019
@NicolasMahe NicolasMahe deleted the refactoring/service/simplify-deleteVolumes branch April 17, 2019 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants