service: move some types to service.go #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this improvement eventually will be made for all other types as well when we start merging small files together in service pkg. this one is needed to be made now to simplify the review of service Manager that will be introduced soon.
krhubert
previously approved these changes
Apr 19, 2019
ilgooz
force-pushed
the
refactoring/service/type-organization
branch
from
8d2c23b
to
d27d646
Compare
krhubert
approved these changes
Apr 19, 2019
NicolasMahe
approved these changes
Apr 19, 2019
It is to make it easy the review the next PR here #904. Otherwise you'll see more code changes on #904 where some blocks of code is removed from some files and added to other ones. It's hard to see if there are any lines of code is actually changed or not during this kind code move. with this quick update, you'll only see file names are renamed and that's all. no extra new files, no file deletions and no having blocks of code moved to other files. -- |
antho1404
approved these changes
Apr 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.