Make marketplace configurable by the core #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krhubert
reviewed
May 3, 2019
| @@ -7,6 +7,9 @@ MESG_LOG_LEVEL=${MESG_LOG_LEVEL:-debug} | |||
| MESG_LOG_FORCECOLORS=${MESG_LOG_FORCECOLORS:-false} | |||
| VERSION=local | |||
| LDFLAGS="-X 'github.com/mesg-foundation/core/version.Version=$VERSION'" | |||
| LDFLAGS+=" -X 'github.com/mesg-foundation/core/config.EnvMarketplaceEndpoint=https://ropsten.infura.io/v3/6115ae2531f64c04a9a392cf500e5fbe'" | |||
There was a problem hiding this comment.
We can set it directly in the mesg.yaml of the service, in that case everone can deploy and use it without dev-core script.
EDIT:
Those values were in the mesg.yaml, what is the reason to move it here? We can left it in mesg.yaml and overwrite via config if needed
There was a problem hiding this comment.
The problem is in the file config/services.go. It always replace the env.
It could create the env map dynamically only if the variable contains something...
It could be improved later on. Let's merge it this way for now.
krhubert
previously approved these changes
May 3, 2019
NicolasMahe
approved these changes
May 3, 2019
|
I added the mainnet data 👍 See the deployed marketplace: https://etherscan.io/address/0x0c6e8d0ec4770fda8a56cd912392d2ff14822952 |
krhubert
approved these changes
May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need a way to use the marketplace in dev (ropsten) and prod (on the mainnet)
@NicolasMahe please update
scripts/build-core.shwhen you have the contract on the mainnet