service: fix deleting volumes for services never started before #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if service is never started before, data volume won't be created and Docker Engine will return with the not found error. therefore, we can safely ignore it. fixes #931.
ilgooz
force-pushed
the
fix/service-delete
branch
from
ac315d4
to
4a108c3
Compare
krhubert
approved these changes
May 13, 2019
antho1404
approved these changes
May 13, 2019
antho1404
approved these changes
May 13, 2019
| if err := c.DeleteVolume(source); err != nil { | ||
| // if service is never started before, data volume won't be created and Docker Engine | ||
| // will return with the not found error. therefore, we can safely ignore it. | ||
| if err := c.DeleteVolume(source); err != nil && !client.IsErrNotFound(err) { |
There was a problem hiding this comment.
could be done directly in the DeleteVolume function that ignores the error to avoid the dependency with docker but it's fine like that too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #931