Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2nd step of simplification of task output - change internal structure #964

Merged
merged 6 commits into from
May 22, 2019

Conversation

krhubert
Copy link
Contributor

depend on #963

@NicolasMahe NicolasMahe changed the base branch from dev to feature/single-output May 20, 2019 08:11
@antho1404
Copy link
Member

some tests are failing because of the InvalidTaskOutputError type that has an empty TaskOutputKey

@krhubert
Copy link
Contributor Author

they are fixed in 3rd step, so if you can merge this one and then take a look on 3rd it would be great

@mesg-bot
Copy link
Member

This pull request has been mentioned on MESG Community. There might be relevant details there:

https://forum.mesg.com/t/simplification-of-the-tasks-output/265/6

NicolasMahe
NicolasMahe previously approved these changes May 22, 2019
@NicolasMahe
Copy link
Member

NicolasMahe commented May 22, 2019

Test are fixed with commit b5bbeae

@krhubert you should have pick this commit into this PR. It would have been cleaner.

EDIT: I pick the commit and put it in this branch for you

EDIT2: also pick commit fde8b29 to fix test

NicolasMahe
NicolasMahe previously approved these changes May 22, 2019
@antho1404 antho1404 merged commit 76def4c into feature/single-output May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants