Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mv Engine] Rename core to engine in config #970

Merged
merged 3 commits into from
May 20, 2019
Merged

[mv Engine] Rename core to engine in config #970

merged 3 commits into from
May 20, 2019

Conversation

NicolasMahe
Copy link
Member

@NicolasMahe NicolasMahe commented May 20, 2019 •
edited
Loading

No description provided.

@NicolasMahe NicolasMahe changed the base branch from dev to rename-engine May 20, 2019 06:10
krhubert
krhubert reviewed May 20, 2019
View reviewed changes
Copy link
Contributor

@krhubert krhubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's good to make this name constant for example in version package

const Name = "engine"

and import this to config and container.

antho1404
antho1404 previously approved these changes May 20, 2019
View reviewed changes
@antho1404 antho1404 merged commit 088af42 into rename-engine May 20, 2019
@antho1404 antho1404 deleted the engine/config branch May 20, 2019 15:56
@NicolasMahe NicolasMahe mentioned this pull request May 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krhubert krhubert krhubert left review comments

@antho1404 antho1404 antho1404 approved these changes

@ilgooz ilgooz ilgooz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NicolasMahe @antho1404 @krhubert @ilgooz