Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5th step - Remove output from service package #973

Merged
merged 2 commits into from
May 22, 2019
Merged

5th step - Remove output from service package #973

merged 2 commits into from
May 22, 2019

Conversation

krhubert
Copy link
Contributor

No description provided.

@krhubert krhubert changed the title Use only one output in protobuf file 5th step - Use only one output in protobuf file May 21, 2019
@mesg-bot
Copy link
Member

This pull request has been mentioned on MESG Community. There might be relevant details there:

https://forum.mesg.com/t/simplification-of-the-tasks-output/265/6

@NicolasMahe
Copy link
Member

NicolasMahe commented May 22, 2019 •
edited
Loading

@krhubert please include the dependant PRs

EDIT: please rebase on feature/single-output-pt-4 and change this PR's base to feature/single-output-pt-4

@krhubert krhubert changed the base branch from feature/single-output to feature/single-output-pt-4 May 22, 2019 06:05
@krhubert krhubert force-pushed the feature/single-output-pt-4 branch from f106d6f to ad29d5c Compare May 22, 2019 06:20
@krhubert krhubert force-pushed the feature/single-output-pt-5 branch from a516604 to 625840c Compare May 22, 2019 06:20
@NicolasMahe NicolasMahe changed the base branch from feature/single-output-pt-4 to feature/single-output May 22, 2019 07:47
NicolasMahe
NicolasMahe reviewed May 22, 2019
View reviewed changes
execution/execution.go Outdated Show resolved Hide resolved
antho1404
antho1404 reviewed May 22, 2019
View reviewed changes
api/api.go Outdated Show resolved Hide resolved
NicolasMahe
NicolasMahe reviewed May 22, 2019
View reviewed changes
api/api.go Outdated Show resolved Hide resolved
@krhubert krhubert force-pushed the feature/single-output-pt-5 branch from 625840c to 5a1b0d5 Compare May 22, 2019 09:57
@krhubert krhubert changed the title 5th step - Use only one output in protobuf file 6th step - Use only one output in protobuf file May 22, 2019
@krhubert krhubert changed the title 6th step - Use only one output in protobuf file 5th step - Remove output from service package May 22, 2019
@antho1404 antho1404 merged commit 5ea8078 into feature/single-output May 22, 2019
@antho1404 antho1404 deleted the feature/single-output-pt-5 branch May 22, 2019 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antho1404 antho1404 antho1404 approved these changes

@NicolasMahe NicolasMahe NicolasMahe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krhubert @mesg-bot @NicolasMahe @antho1404