Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update marketplace to single output #987

Merged
merged 4 commits into from
May 29, 2019

Conversation

NicolasMahe
Copy link
Member

@NicolasMahe NicolasMahe commented May 24, 2019

The system service marketplace need to be updated to single output.

  • update mesg.yml. Already done
  • Update codebase to use new mesg-js beta
    • return only outputData in task function
    • throw error if any in task function

@NicolasMahe NicolasMahe changed the base branch from dev to feature/single-output May 24, 2019 09:58
@krhubert krhubert requested a review from antho1404 May 24, 2019 16:09
@krhubert krhubert force-pushed the feature/single-output-marketplace branch from c8e458f to 7e8a657 Compare May 27, 2019 06:50
@NicolasMahe NicolasMahe marked this pull request as ready for review May 29, 2019 07:42
@NicolasMahe
Copy link
Member Author

NicolasMahe commented May 29, 2019

This PR is working and ready to review.
The last todo can be done in another PR after the mesg-js lib has been updated!

Copy link
Member

@antho1404 antho1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

➜  marketplace git:(feature/single-output-marketplace) docker build .
Sending build context to Docker daemon  400.9kB
Step 1/7 : FROM node:10.11.0
 ---> 8672b25e842c
Step 2/7 : WORKDIR /app
 ---> Using cache
 ---> 7516b530e8ed
Step 3/7 : COPY ./package* ./
 ---> 1b00b8edcef5
Step 4/7 : RUN npm install
 ---> Running in 63bd2a87dba3
Unhandled rejection Error: Command failed: /usr/bin/git checkout beta
error: pathspec 'beta' did not match any file(s) known to git.

    at ChildProcess.exithandler (child_process.js:289:12)
    at ChildProcess.emit (events.js:182:13)
    at maybeClose (internal/child_process.js:962:16)
    at Socket.stream.socket.on (internal/child_process.js:381:11)
    at Socket.emit (events.js:182:13)
    at Pipe._handle.close (net.js:606:12)

Copy link
Member

@antho1404 antho1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lib fixed, ready to merge for me

@NicolasMahe
Copy link
Member Author

@antho1404 modif are good 👍

@NicolasMahe NicolasMahe merged commit e458453 into feature/single-output May 29, 2019
@NicolasMahe NicolasMahe deleted the feature/single-output-marketplace branch May 29, 2019 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants