Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode and decode Hashes from and to base58 #95

Closed
NicolasMahe opened this issue Aug 29, 2019 · 0 comments · Fixed by mesg-foundation/cli#138
Closed

Encode and decode Hashes from and to base58 #95

NicolasMahe opened this issue Aug 29, 2019 · 0 comments · Fixed by mesg-foundation/cli#138

Comments

@NicolasMahe
Copy link
Member

Related to https://github.com/mesg-foundation/mesg-js/issues/123 and mesg-foundation/engine#1265.

Now that hashes are in bytes instead of string on the gRPC API, the cli should display and parse the hash from / to base58.

I suggest to create helpers function directly in mesg-js so it can be used by the lib internally but also by cli (see issue https://github.com/mesg-foundation/mesg-js/issues/123).

@antho1404 antho1404 transferred this issue from mesg-foundation/cli Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant