Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Hash type from string to bytes #32

Closed
NicolasMahe opened this issue Aug 29, 2019 · 0 comments · Fixed by mesg-foundation/mesg-js#124
Closed

Update Hash type from string to bytes #32

NicolasMahe opened this issue Aug 29, 2019 · 0 comments · Fixed by mesg-foundation/mesg-js#124

Comments

@NicolasMahe
Copy link
Member

Because of mesg-foundation/engine#1270, hashes are now in bytes instead of string over the gRPC API.
The lib needs to be updated to reflect it.

The hashes should still be display to the user as base58 but also parsed from base58.
So it would make sense to add helpers function directly in the lib.

The marketplace service is using base-x to convert buffer to and from base58.

@antho1404 antho1404 transferred this issue from mesg-foundation/mesg-js Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant