Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link CTA menu get started #241

Merged
merged 5 commits into from
May 4, 2020
Merged

Conversation

EmmanuelDrouin
Copy link
Member

@EmmanuelDrouin EmmanuelDrouin commented Apr 7, 2020

  • Replace internal link of the "get started" CTA in the menu by an external link to the get started page of the docs

To do:

  • Fix issue with the "menu" component
    @antho1404 External links are not working if they are at the first level of the menu. They are working if they are at the second level of the menu (submenu)

@mesg-bot
Copy link
Member

mesg-bot commented Apr 7, 2020

Deploy preview for mesg ready!

Built with commit 6005ff1

https://deploy-preview-241--mesg.netlify.app

@antho1404
Copy link
Member

@EmmanuelDrouin fix done, now the button can accept external links as well

@EmmanuelDrouin
Copy link
Member Author

EmmanuelDrouin commented Apr 30, 2020

@antho1404 the issue is still here. The button in the menu is still not working with external links.
I've double check, every components are up to date. But the issue remains.

I don't think the issue comes from the button. Every external links at the first level of the menu are not working. They are working only if they are in a sub-menu.

@antho1404
Copy link
Member

It's working for me https://deploy-preview-241--mesg.netlify.app/
Make sure to refresh your cache maybe (cmd+shift+r)

@EmmanuelDrouin
Copy link
Member Author

@antho1404 i can see on the deploy-preview it's working. For me it's not working locally (on my localhost), even with the cache refreshed. I don't know why. But anyway looks good on the preview, so let's merge this PR and move on.

@antho1404
Copy link
Member

For information, it's probably because of your previous install

rm -rf node_modules
npm i

This should fix your issue

@antho1404 antho1404 merged commit 690cbd3 into master May 4, 2020
@antho1404 antho1404 deleted the update-cta-menu-get-started-link branch May 4, 2020 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants