Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Release Drafter #25

Merged
merged 2 commits into from
Aug 24, 2020
Merged

Conversation

UdokaVrede
Copy link
Contributor

@UdokaVrede UdokaVrede commented Aug 20, 2020

Signed-off-by: Udoka [email protected]

Description

This PR fixes issue: Add Release Drafter for the repository #24
Current Behavior
Each of the layer5 repositories needs releaseDrafter automation as had been done in the meshery project which takes care of drafting release notes.

Desired Behavior
Add ReleaseDrafter configuration yaml file & GitHub Action.

Action performed
Added the Github Action & configuration yaml file.

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@welcome
Copy link

welcome bot commented Aug 20, 2020

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@PluckyPrecious
Copy link

Hi @UdokaVrede there’s no content in the commit file, kindly push. And also do well to edit the description and mention the issue it fixes. 😊

@UdokaVrede
Copy link
Contributor Author

@PluckyPrecious noted I'd check back again

@Anita-ihuman
Copy link
Contributor

Looks good
Nice work
@UdokaVrede

@leecalcote
Copy link
Member

@UdokaVrede thank you for contributing. 👍

If you would, please edit the description fo the PR include the issue # that it fixes (here's why - https://docs.github.com/en/enterprise/2.16/user/github/managing-your-work-on-github/closing-issues-using-keywords)

@Ruth-ikegah
Copy link
Contributor

Nice @UdokaVrede. As @PluckyPrecious said Try editing the description.
This PR fixes # the issue number

@UdokaVrede
Copy link
Contributor Author

UdokaVrede commented Aug 20, 2020

Done thanks @leecalcote @Anita-ihuman @PluckyPrecious. Awaiting reviews.

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Nice work, @UdokaVrede. 👍

@Anita-ihuman
Copy link
Contributor

It looks nice @udokaVreda
Great job

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @UdokaVrede! 👍

@leecalcote leecalcote merged commit f1d5302 into meshery:master Aug 24, 2020
@welcome
Copy link

welcome bot commented Aug 24, 2020

Thanks for your contribution to the Layer5 community! 🎉

Congrats!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants