Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI]: Meshery extension catalog modal image height fix #1882

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

SAHU-01
Copy link
Contributor

@SAHU-01 SAHU-01 commented Aug 19, 2024

Description

This PR fixes #1881

Notes for Reviewers
I've resolved this by adding a height:100% to the image tag CSS

image image

Signed commits

  • Yes, I signed my commits.

Copy link

welcome bot commented Aug 19, 2024

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit f50f1b7
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/671e8ce5b1f4ac0008298f0a
😎 Deploy Preview https://deploy-preview-1882--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SAHU-01 SAHU-01 changed the title feat(UI): Meshery extension catalog modal image height fix [UI]: Meshery extension catalog modal image height fix Aug 19, 2024
amitamrutiya
amitamrutiya previously approved these changes Aug 19, 2024
Copy link

@Ashparshp Ashparshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @SAHU-01.

Copy link
Member

@sudhanshutech sudhanshutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SAHU-01 few snapshots images is streched out . Is this due to this change? I think yes!
image

@Ashparshp
Copy link

@SAHU-01, Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.

@SAHU-01
Copy link
Contributor Author

SAHU-01 commented Aug 26, 2024

@SAHU-01 few snapshots images is streched out . Is this due to this change? I think yes! image

Yes, I'll check these and fix it!
Thank you for highlighting the same.

Copy link
Member

@sudhanshutech sudhanshutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SAHU-01 will you remove the unnecessary added lines , the lint changes.

@SAHU-01
Copy link
Contributor Author

SAHU-01 commented Aug 28, 2024

Sure I'll get rid of the linting changes.

@Ashparshp Ashparshp added the issue/remind Issue progress check label Sep 9, 2024
Copy link

github-actions bot commented Sep 9, 2024

Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@Ashparshp
Copy link

@SAHU-01, just a reminder in case you missed this.

@vishalvivekm
Copy link
Member

@SAHU-01 ?

@SAHU-01
Copy link
Contributor Author

SAHU-01 commented Oct 14, 2024

@vishalvivekm thank you for highlighting this, I'll remove the unecessary linting changes .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/website issue/remind Issue progress check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI]: Center align images inside Card Modal of extensions page
5 participants