Add default values for required fields in artifacthub-pkg #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris C <[email protected]>
|
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. |
hamza-mohd
approved these changes
Aug 21, 2024
| "github.com/layer5io/meshkit/models/catalog/v1alpha1" | ||
| ) | ||
|
|
||
| func BuildArtifactHubPkg(name, downloadURL, user, version, createdAt string, catalogData *v1alpha1.CatalogData) *ArtifactHubMetadata { | ||
| artifacthubPkg := &ArtifactHubMetadata{ | ||
| Name: toKebabCase(name), | ||
| DisplayName: name, | ||
| Description: catalogData.PatternInfo, | ||
| Description: valueOrElse(catalogData.PatternInfo, "A Meshery Design"), |
There was a problem hiding this comment.
This is really helpful. 👏
Signed-off-by: Mohd Hamza <[email protected]>
|
Merge conflict eliminated. |
|
Thanks for your contribution to Meshery! 🎉 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where the artifacthub-pkg generated during export of an OCI archive would be missing required fields. This adds default values if the value in the
catalogDatais empty. With this change a user can export an OCI and extract the artifacthub-pkg and drop it right into an ArtifactHub repo.Notes for Reviewers
Signed commits