Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Field to Specify Device IP #663

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Adds Field to Specify Device IP #663

merged 1 commit into from
Jul 17, 2023

Conversation

jp-bennett
Copy link
Collaborator

Closes #472

@jp-bennett
Copy link
Collaborator Author

Also partially address #649 .

@jp-bennett jp-bennett mentioned this pull request Jul 17, 2023
Closed
@jp-bennett
Copy link
Collaborator Author

@andrekir Requested changes made. Tested and it's still working as expected. Thanks!

andrekir
andrekir requested changes Jul 17, 2023
View reviewed changes
Copy link
Member

@andrekir andrekir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks really good. added one small request.

app/src/main/java/com/geeksville/mesh/ui/SettingsFragment.kt Outdated Show resolved Hide resolved
@jp-bennett
Adds Field to Specify Device IP
192896c 
Closes meshtastic#472

Signed-off-by: Jonathan Bennett <[email protected]>
@jp-bennett
Copy link
Collaborator Author

looks really good. added one small request.

Cleaned that up. And some extra bits in the fragment XML that didn't need changed.

@andrekir
Copy link
Member

looks great, thank you!

@andrekir andrekir merged commit bbb9ca3 into meshtastic:master Jul 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrekir andrekir andrekir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow adding nodes via IP connection by manually providing an IP/host
2 participants
@jp-bennett @andrekir