add centerMapAt util to MeshMap #918
Conversation
|
|
powersjcb
changed the title
powersjcb
changed the title
| @@ -74,6 +86,9 @@ struct MeshMap: View { | |||
| .mapControlVisibility(.automatic) | |||
| } | |||
| .controlSize(.regular) | |||
| .onMapCameraChange(frequency: MapCameraUpdateFrequency.continuous, { context in | |||
| distance = context.camera.distance | |||
There was a problem hiding this comment.
map zoom distance value isn't available through position (position.camera == nil). A few discussions I found recommended this solution.
| # Run SwiftLint --fix on each file | ||
| for ((i = 0; i < count; i++)); do | ||
| file_var="SCRIPT_INPUT_FILE_$i" | ||
| file_path=${!file_var} | ||
| echo "Fixing $file_path" | ||
| $SWIFT_LINT --fix --path "$file_path" | ||
| $SWIFT_LINT --fix "$file_path" |
There was a problem hiding this comment.
--path was removed in a recent versions of swiftlint. This should be compatible with older versions of swiftlint since it's been deprecated for at least 2 years before that.
| @@ -92,6 +107,7 @@ struct MeshMap: View { | |||
| Logger.services.error("Unable to convert local point to coordinate on map.") | |||
| return | |||
| } | |||
| centerMapAt(coordinate: coordinate) | |||
There was a problem hiding this comment.
This was originally a quick hack for testing (since I don't have a way to access node data from Simulator), but centering the map on the location a waypoint is being proposed actually felt very intuitive so I decided to open this PR.
| @@ -33,6 +33,7 @@ struct MeshMap: View { | |||
| @Namespace var mapScope | |||
| @State var mapStyle: MapStyle = MapStyle.standard(elevation: .flat, emphasis: MapStyle.StandardEmphasis.muted, pointsOfInterest: .excludingAll, showsTraffic: false) | |||
| @State var position = MapCameraPosition.automatic | |||
| @State private var distance = 10000.0 | |||
There was a problem hiding this comment.
I think this initial value will only matter when someone tries to deep link to a node before they've zoomed into an area on this map. (initial map zoom is set separately by MapCameraBounds(..., maximumDistance: .infinity),
It might be nice to tune this to whatever we find to be the most common ranges are when someone's wanting to view a point of interest. (be it waypoint or node)
powersjcb
force-pushed
the
powersjcb/nodes-map-deep-links
branch
from
43a72aa
to
089022d
Compare
What changed?
Added an animated centerMapAt utility function to the MeshMap View. It centers the view window on a location and resets map orientation to north and sets 3d views to top-down.
The create Waypoint feature now uses this to align/center the map on the selected location.
Why did it change?
centerMapAtwill be necessary to support deep linking from node/chat views into the Mesh Map.How is this tested?
Manually tested in Simulator.
Screenshots/Videos (when applicable)
centerMapAt.mp4
Checklist