Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable deep sleep for nRF and force shutdown for RAK463x on discharged battery #2040

Merged
merged 7 commits into from
Dec 15, 2022

Conversation

D4rk4
Copy link
Contributor

@D4rk4 D4rk4 commented Dec 14, 2022

Fix for #2022

@github-actions
Copy link
Contributor

github-actions bot commented Dec 14, 2022

🤖 Pull request artifacts

file commit
pr2040-firmware-2.0.8.72504a5.zip 72504a5

thebentern added a commit to meshtastic/artifacts that referenced this pull request Dec 14, 2022
@caveman99
Copy link
Member

I'm curious, is this really triggering for you? it wants 10 samples below min_battery and if one of those is above it will start counting over at zero. If it is triggering there may be some underlying problem in the ADC routines.

@D4rk4
Copy link
Contributor Author

D4rk4 commented Dec 14, 2022

@caveman99 yes it's hit my node =(
Yes, it looks like voltage fluctuation, I'm already soldered supercap in parallel to the battery, but it did not help. So it's not a hardware/18650 issue.

Also it's not correct by a logic - if you battarey is really discharged SDS triggered and kill the node. After battery recharge, your node still keeps SDS state, and you need to reset the board via the hardware button. As result, you can't use NRF hardware as an autonomous off-grid node =(

Please give me time for sanity validation of this fix in different conditions.

@D4rk4 D4rk4 changed the title Disable nRF sleep on discharged battery Disable nRF deep sleep on discharged battery Dec 14, 2022
@D4rk4 D4rk4 changed the title Disable nRF deep sleep on discharged battery [DRAFT] Disable nRF deep sleep on discharged battery Dec 14, 2022
@caveman99 caveman99 marked this pull request as draft December 14, 2022 11:47
@caveman99
Copy link
Member

Sure, i converted your PR to a draft, let's get to the bottom of this.

thebentern added a commit to meshtastic/artifacts that referenced this pull request Dec 14, 2022
thebentern added a commit to meshtastic/artifacts that referenced this pull request Dec 14, 2022
thebentern added a commit to meshtastic/artifacts that referenced this pull request Dec 14, 2022
@D4rk4 D4rk4 changed the title [DRAFT] Disable nRF deep sleep on discharged battery Disable nRF deep sleep on discharged battery Dec 15, 2022
@D4rk4
Copy link
Contributor Author

D4rk4 commented Dec 15, 2022

@caveman99
I checked 2 cycles with full charge/full discharge. All working like expected (no sudden poweroff and node got online after external power connected).
May you accept this PR? Without this, RAK-based off-grid nodes can't work properly from battery power.

@D4rk4 D4rk4 changed the title Disable nRF deep sleep on discharged battery Disable deep sleep for nRF and force shutdown for RAK463x on discharged battery Dec 15, 2022
@caveman99 caveman99 marked this pull request as ready for review December 15, 2022 10:19
Copy link
Member

@caveman99 caveman99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to investigate the measurements further, this will improve user experience for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants