-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable deep sleep for nRF and force shutdown for RAK463x on discharged battery #2040
Conversation
🤖 Pull request artifacts
|
I'm curious, is this really triggering for you? it wants 10 samples below min_battery and if one of those is above it will start counting over at zero. If it is triggering there may be some underlying problem in the ADC routines. |
@caveman99 yes it's hit my node =( Also it's not correct by a logic - if you battarey is really discharged SDS triggered and kill the node. After battery recharge, your node still keeps SDS state, and you need to reset the board via the hardware button. As result, you can't use NRF hardware as an autonomous off-grid node =( Please give me time for sanity validation of this fix in different conditions. |
Sure, i converted your PR to a draft, let's get to the bottom of this. |
@caveman99 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to investigate the measurements further, this will improve user experience for the time being.
Fix for #2022