Re issue: #2496 Populate the position log entries from PositionModule with data fields #2839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
includes datafields with no data as 0
|
|
jp-bennett
approved these changes
Sep 27, 2023
|
CI is complaining that trunk check found a formatting issue. Try running "trunk check src/modules/PositionModule.cpp" and commit the changes it suggests. |
thebentern
approved these changes
Sep 27, 2023
🤖 Pull request artifacts
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include position datafields in log entries. If the there is no data in the packet it displays as 0 in the log. eg:
INFO | ??:??:?? 25 [Router] POSITION node=25d62b24 l=17 latI=208759619 lonI=-1565037628 msl=113 hae=0 geo=0 pdop=0 hdop=0 vdop=0 siv=0 fxq=0 fxt=0 pts=0 time=1695811433regarding issue #2496