"Scan and Select" input for Canned Messages #4365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing CI, needs some more guarding. |
todd-herbert
force-pushed
the
scan-and-select
branch
from
0698fef
to
286923f
Compare
|
Ooooh so this is a single additional button on GPIO in addition to a user button? Very cool! 🎉 |
|
This is very cool indeed |
todd-herbert
force-pushed
the
scan-and-select
branch
from
286923f
to
ec5f473
Compare
* Indicate current selection with indent rather than inverse text * Avoid large text on "sending" and delivery report pop-ups * Fit SNR and RSSI details on screen
The old function struggled to distingush between images on the canned-message frame, failing to update when scrolling between messages. No real justification for the new algorithm, other than "it works" and doesn't seem "too expensive". For context, this function runs once a second.
todd-herbert
force-pushed
the
scan-and-select
branch
from
ec5f473
to
8782ee3
Compare
|
I'd be keen to get this in for 2.4.2 if possible, to try catch as many new VME213 and VME290 boards with this PRs default module config. Otherwise they'll probably miss out on the feature until they erase the flash next. |
|
Let's do it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
A new input source for the canned message module, using a single push-button connected to GPIO.
Short press: scroll through the pre-set messages
Long press: send the currently highlighted message to primary channel
Why
Some boards have an additional built-in button, which is currently unused. The proposed "scan and select" input is an attempt to make productive use of the feature.
PR enables canned messages as default for Heltec VME290 and VME213 boards.
By default, the module is partially configured: pins and input method are set, however no messages are defined.
Pressing the configured button during this state alerts on-screen: "no canned messages". This will prompt the user to either configure messages, or disable the module entirely.
Doc for proposed changes
scan-and-select-vme290.mp4
scan-and-select-tbeam.mp4