Implement optional hops_away on NodeInfo/Lite #4747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebentern
requested review from
caveman99,
ianmcorvidae,
GUVWAF and
garthvh
GUVWAF
approved these changes
Sep 17, 2024
ianmcorvidae
approved these changes
Sep 17, 2024
|
Just saw the client-dev perspective question (albeit not directed at me). I think null is better as well. The local node is basically -1 hops "away" but null is better I think, haha |
panaceya
pushed a commit
to mesh-mk-ua/meshtastic-firmware
that referenced
this pull request
Sep 20, 2024
* Implement optional hops_away on NodeInfo/Lite * Trunk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@garthvh question from the app consumer perspective: Do you want the current node to have a null hops_away or hops_away of zero? I elected to use the former.