Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channel Page: Remove ID & Number and Enter Descriptions #133

Merged
merged 4 commits into from
Sep 30, 2023
Merged

Channel Page: Remove ID & Number and Enter Descriptions #133

merged 4 commits into from
Sep 30, 2023

Conversation

pdxlocations
Copy link
Member

@pdxlocations pdxlocations commented Sep 30, 2023 •
edited
Loading

This PR applies to the Channel Page and:

  1. removes the ID and Channel Number fields.
  2. replaces "description" with descriptions

closes #126

Screenshot 2023-09-30 at 10 34 50 AM

@ajmcquilkin
Copy link
Member

Looks solid! I don't have review perms, might be worth asking @sachaw or someone on the admin team to approve

@pdxlocations pdxlocations marked this pull request as draft September 30, 2023 17:09
@pdxlocations pdxlocations marked this pull request as ready for review September 30, 2023 17:35
@thebentern thebentern merged commit 08c064d into meshtastic:master Sep 30, 2023
1 of 2 checks passed
@pdxlocations pdxlocations deleted the channel-descriptions branch September 30, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thebentern thebentern thebentern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ISSUE] Channel settings "Channel Number" & "ID" available
3 participants
@pdxlocations @ajmcquilkin @thebentern