Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSK Generator #266

Merged
merged 11 commits into from
Aug 15, 2024
Merged

PSK Generator #266

merged 11 commits into from
Aug 15, 2024

Conversation

Hunter275
Copy link
Member

@Hunter275 Hunter275 commented Jul 28, 2024 •
edited
Loading

Added a password generator to match iOS ability.

TODO:
Button changes input value ✅
PSK length dropdown changes password generation ✅
PSK key generation ✅
PSK loading from device ✅
PSK saving to device ✅
PSK length validation ✅

@Hunter275
Copy link
Member Author

To generate a password on iOS:

https://github.com/meshtastic/Meshtastic-Apple/blob/07c1018b538ea3bedd72ed243d9041d723650cb4/Meshtastic/Views/Settings/Channels.swift#L17

We use SecRandomCopyBytes() (https://developer.apple.com/documentation/security/1399291-secrandomcopybytes) to create a random input and then we encode it using base64EncodedString()

@Hunter275 Hunter275 changed the title added password generator PSK Generator Jul 28, 2024
@Hunter275 Hunter275 linked an issue Jul 28, 2024 that may be closed by this pull request
[Bug]: Update Channel Password flavor text #261
Closed
@Hunter275 Hunter275 added enhancement New feature or request help wanted Extra attention is needed minor change This is a minor change parity Feature is in other app (iOS, Android, etc) major change This is a major change and removed minor change This is a minor change labels Jul 29, 2024
@Hunter275 Hunter275 mentioned this pull request Aug 8, 2024
Merged
@Hunter275 Hunter275 marked this pull request as ready for review August 10, 2024 23:54
garthvh
garthvh approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@garthvh garthvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

rcarteraz
rcarteraz approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@rcarteraz rcarteraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fiddled around with it and it's working good for me. Nice work!

@Hunter275 Hunter275 merged commit 2b34d78 into meshtastic:master Aug 15, 2024
3 checks passed
@Hunter275
Copy link
Member Author

Thanks yall

@Hunter275 Hunter275 mentioned this pull request Aug 19, 2024
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thebentern thebentern thebentern approved these changes

@rcarteraz rcarteraz rcarteraz approved these changes

@garthvh garthvh garthvh approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed major change This is a major change parity Feature is in other app (iOS, Android, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Update Channel Password flavor text
4 participants
@Hunter275 @garthvh @rcarteraz @thebentern