-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: allow users to pass options directly to Meson #167
Conversation
1ade225
to
e0379d1
Compare
8b1ffa1
to
8c53be7
Compare
e00acce
to
ff07146
Compare
build-backend = 'mesonpy' | ||
requires = ['meson-python'] | ||
|
||
[tool.mesonpy.args] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be mesonpy
? I think we are settling to meson-python
as project name and it is nice to try to be consistent. Actually, we could even think about using tool.meson
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good point, let's try and update it. We should get rid of mesonpy
everywhere except for in the build-backend = 'mesonpy'
hook line.
I'd prefer meson-python
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whops, I missed this comment 😣
@FFY00 would it be possible to give an example of how to use |
It should be |
Is |
|
ff07146
to
2669466
Compare
Signed-off-by: Filipe Laíns <[email protected]>
2669466
to
5191398
Compare
Great to see this land! One comment left unaddressed, and let's do a few doc updates in a follow-up PR. @FFY00 are you planning to do that? If not I can do it - already have a need to point people to it:) |
That seems wrong, I think it should be This landed with underscores It's nontrivial to figure out the right invocations here, so we need quite a few examples in the docs. Here is another one:
Another follow-up, unrecognized inputs should raise or give a warning, rather than be silently ignored. This will happily continue a build:
|
This was done in gh-218.
This was done in gh-219. I'll open a new issue for the rest. |
Signed-off-by: Filipe Laíns [email protected]
EDIT: closes gh-54