-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly disable pie when pie is false #4651
Comments
Is there any traction here? Here is a test with
And
The only way I can get a statically linked, PIE is with something like the following:
This leads me to the conclusion that pie as an argument is actually broken as the above is required to make Tagging @marc-h38 |
Currently meson supports explicitly turning pie args on, but relies on the default behavior being no-pie. This isn't always the case, and we should explicitly add the correct no pie arguments. Fixes mesonbuild#4651
Currently meson supports explicitly turning pie args on, but relies on the default behavior being no-pie. This isn't always the case, and we should explicitly add the correct no pie arguments. Fixes mesonbuild#4651
Currently meson supports explicitly turning pie args on, but relies on the default behavior being no-pie. This isn't always the case, and we should explicitly add the correct no pie arguments. Fixes mesonbuild#4651
Currently meson supports explicitly turning pie args on, but relies on the default behavior being no-pie. This isn't always the case, and we should explicitly add the correct no pie arguments. Fixes mesonbuild#4651
Currently meson supports explicitly turning pie args on, but relies on the default behavior being no-pie. This isn't always the case, and we should explicitly add the correct no pie arguments. Fixes mesonbuild#4651
Currently meson supports explicitly turning pie args on, but relies on the default behavior being no-pie. This isn't always the case, and we should explicitly add the correct no pie arguments. Fixes mesonbuild#4651
Currently meson supports explicitly turning pie args on, but relies on the default behavior being no-pie. This isn't always the case, and we should explicitly add the correct no pie arguments. Fixes mesonbuild#4651
Currently meson assumes that you either want to force pie on, or get the system default. Which is pretty silly as that is *not* what the documentation suggests. This patch changes the pie args into a tristate, ["true", "false", "default"], where true means add pie on args, false means add pie off args, and default means don't add any args. Default is the default value for both -Db_pie and for the pie argument in executable(). Fixes mesonbuild#4651
Currently meson assumes that you either want to force pie on, or get the system default. Which is pretty silly as that is *not* what the documentation suggests. This patch changes the pie args into a tristate, ["true", "false", "default"], where true means add pie on args, false means add pie off args, and default means don't add any args. Default is the default value for both -Db_pie and for the pie argument in executable(). Fixes mesonbuild#4651
Currently meson assumes that you either want to force pie on, or get the system default. Which is pretty silly as that is *not* what the documentation suggests. This patch changes the pie args into a tristate, ["true", "false", "default"], where true means add pie on args, false means add pie off args, and default means don't add any args. Default is the default value for both -Db_pie and for the pie argument in executable(). Fixes mesonbuild#4651
Currently meson assumes that you either want to force pie on, or get the system default. Which is pretty silly as that is *not* what the documentation suggests. This patch changes the pie args into a tristate, ["true", "false", "default"], where true means add pie on args, false means add pie off args, and default means don't add any args. Default is the default value for both -Db_pie and for the pie argument in executable(). Fixes mesonbuild#4651
Currently meson assumes that you either want to force pie on, or get the system default. Which is pretty silly as that is *not* what the documentation suggests. This patch changes the pie args into a tristate, ["true", "false", "default"], where true means add pie on args, false means add pie off args, and default means don't add any args. Default is the default value for both -Db_pie and for the pie argument in executable(). Fixes mesonbuild#4651
Currently meson assumes that you either want to force pie on, or get the system default. Which is pretty silly as that is *not* what the documentation suggests. This patch changes the pie args into a tristate, ["true", "false", "default"], where true means add pie on args, false means add pie off args, and default means don't add any args. Default is the default value for both -Db_pie and for the pie argument in executable(). Fixes mesonbuild#4651
Currently meson assumes that you either want to force pie on, or get the system default. Which is pretty silly as that is *not* what the documentation suggests. This patch changes the pie args into a tristate, ["true", "false", "default"], where true means add pie on args, false means add pie off args, and default means don't add any args. Default is the default value for both -Db_pie and for the pie argument in executable(). Fixes mesonbuild#4651
Currently meson assumes that you either want to force pie on, or get the system default. Which is pretty silly as that is *not* what the documentation suggests. This patch changes the pie args into a tristate, ["true", "false", "default"], where true means add pie on args, false means add pie off args, and default means don't add any args. Default is the default value for both -Db_pie and for the pie argument in executable(). Fixes mesonbuild#4651
Currently meson assumes that you either want to force pie on, or get the system default. Which is pretty silly as that is *not* what the documentation suggests. This patch changes the pie args into a tristate, ["true", "false", "default"], where true means add pie on args, false means add pie off args, and default means don't add any args. Default is the default value for both -Db_pie and for the pie argument in executable(). Fixes mesonbuild#4651
Currently meson assumes that you either want to force pie on, or get the system default. Which is pretty silly as that is *not* what the documentation suggests. This patch changes the pie args into a tristate, ["true", "false", "default"], where true means add pie on args, false means add pie off args, and default means don't add any args. Default is the default value for both -Db_pie and for the pie argument in executable(). Fixes mesonbuild#4651
@dcbaker I see that you spent some effort on this early last year - any chance you might pick it up again? (I.e. +1, I also ran into this issue.) |
I also ran into this issue. What work is left to make this upstream? |
I had patches that changed the behavior, but we wanted to make the behavior remain the same, ie, "nothing means add no flags and whatever the compiler defaults to" when you don't pass either |
Also, we realized that pic has the same broken behavior, and needs to be fixed too. |
From what I can tell reading 9983262, it looks like you did do it 🙂 |
From closed #6415:
I haven't found any rewrite. |
I have patches, but they’re blocked on #10714 |
A lot of the platforms now has pie enabled by default, without any compiler flags. Maybe when the user explicitly set
b_pie
to be false, meson should explicitly disable pie with-no-pie
.The text was updated successfully, but these errors were encountered: