Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove build.{,cross_}compilers #4771

Closed
Ericson2314 opened this issue Jan 14, 2019 · 0 comments · Fixed by #5397
Closed

Remove build.{,cross_}compilers #4771

Ericson2314 opened this issue Jan 14, 2019 · 0 comments · Fixed by #5397

Comments

@Ericson2314
Copy link
Member

#4755 made those fields alias coredata's. But that complicates copying logic in an ad-hoc way. I don't think the complexity is worth the shorthand; it would be better to just remove those fields, and the copying special case, from build and use build.environment.coredata.{,cross_}compilers everywhere.

Not sure if we have any "new contributor" or "easy" tag, but this is a straightforward refactor, albeit one that will take a few test runs and greps to catch everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant