Remove compilers from build object #5397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⚔️ conflicts. |
It doesn't make much sense to have this and not also have cross-compilers (so any use of this is already pretty suspect as probably wrong when cross-compiling). This information is accessible anyhow via environment.coredata.
After mesonbuild#4445, the code in both branches of this conditional is the same.
Switch from build.compiler to environment.coredata.compiler and likewise from build.cross_compiler to environment.coredata.cross_compiler in backends. (Only seems to be actually used in ninja backend).
The actual data is in Coredata (which is serialized) and we just held a reference in Build for (in)convenience.
jon-turney
force-pushed
the
remove-compilers-from-build-object
branch
from
7fcb82d
to
4da92e7
Compare
|
Rebased to resolve conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A step on the way to sorting out #2392.
Closes #4771.