Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DUB dependencies (with cache description) #12143

Closed
wants to merge 3 commits into from

Conversation

rtbo
Copy link
Contributor

@rtbo rtbo commented Aug 20, 2023

Two PR has been merged into DUB which will help to use DUB packages with Meson:

dub build --deep will build exactly the same libraries (same build-id) as the packages returned by dub describe.
So for a complex dependency tree (e.g. vibe-d), a single command (entered by the user) will build all the needed sub-libraries, and then meson will be able to find them all in a single shot.

This PR fixes #11773 and supersedes #11798

@rtbo rtbo requested a review from jpakkane as a code owner August 20, 2023 12:44
@rtbo
Copy link
Contributor Author

rtbo commented Oct 7, 2023

I have now mypy errors I didn't have:

 mesonbuild/dependencies/dub.py:30:26: error: Name "T.TypedDict" is not defined  [name-defined]

Is there a deprecation around TypedDict?

@denizzzka
Copy link

denizzzka commented Feb 8, 2024

@rtbo Thank you very much for the work on DUB-related PRs! Is here any news?

@eli-schwartz
Copy link
Member

Is there a deprecation around TypedDict?

Try importing it from typing_extensions instead, to handle versions of python before it was introduced.

@eli-schwartz
Copy link
Member

Also please remember to squash the lint changes into their respective commits once you are ready for merging.

@ricardaxel
Copy link

Hello @rtbo, thanks for the work ! Is there any reason that this PR is not yet merged to master ?

@thesamesam
Copy link
Collaborator

thesamesam commented Jul 16, 2024

Could you look at the CI failures? Thanks.

Let us know if you need help.

Copy link
Member

@dcbaker dcbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small (and one big) thing here. Thanks for looking at this

mesonbuild/dependencies/dub.py Outdated Show resolved Hide resolved
mesonbuild/dependencies/dub.py Outdated Show resolved Hide resolved
mesonbuild/dependencies/dub.py Outdated Show resolved Hide resolved
@dcbaker
Copy link
Member

dcbaker commented Jul 24, 2024

I really need this work to land soon, so I went ahead and squashed all of the fixups back into the commits they applied to, and applied the changes that Eli and I had requested. This is good stuff, and I'm excited to get it landed

rtbo added 3 commits July 30, 2024 14:36
 - check version of DUB for compatibility with Meson
 - use "cacheArtifactPath" to locate DUB libraries in the cache
 - propose `dub build --deep` command to Meson users for missing DUB
   packages

Depending on DUB version, it will look either in the old cache structure
or use this new `dub describe` entry.
Which was broken because of DubDependency.class_dubbin typing change.
Passed under radar because Dub tests were deactivated in the same PR.
@eli-schwartz
Copy link
Member

Thanks @thesamesam for debugging the cause of the Windows failure and fixing it.

mmomtchev pushed a commit to mmomtchev/hadron that referenced this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenSUSE CI image builder fails to run dub tests
6 participants