-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DUB dependencies (with cache description) #12143
Conversation
96571ba
to
1b574eb
Compare
I have now
Is there a deprecation around |
@rtbo Thank you very much for the work on DUB-related PRs! Is here any news? |
Try importing it from typing_extensions instead, to handle versions of python before it was introduced. |
Also please remember to squash the lint changes into their respective commits once you are ready for merging. |
Hello @rtbo, thanks for the work ! Is there any reason that this PR is not yet merged to master ? |
Could you look at the CI failures? Thanks. Let us know if you need help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of small (and one big) thing here. Thanks for looking at this
d58f929
to
ee0379c
Compare
I really need this work to land soon, so I went ahead and squashed all of the fixups back into the commits they applied to, and applied the changes that Eli and I had requested. This is good stuff, and I'm excited to get it landed |
- check version of DUB for compatibility with Meson - use "cacheArtifactPath" to locate DUB libraries in the cache - propose `dub build --deep` command to Meson users for missing DUB packages Depending on DUB version, it will look either in the old cache structure or use this new `dub describe` entry.
Which was broken because of DubDependency.class_dubbin typing change. Passed under radar because Dub tests were deactivated in the same PR.
ee0379c
to
1496259
Compare
Thanks @thesamesam for debugging the cause of the Windows failure and fixing it. |
Two PR has been merged into DUB which will help to use DUB packages with Meson:
dub describe
output the path of the built library in Dub's cachedub build
dlang/dub#2647dub build --deep
switch to build a complete tree of static librariesdub build --deep
will build exactly the same libraries (same build-id) as the packages returned bydub describe
.So for a complex dependency tree (e.g.
vibe-d
), a single command (entered by the user) will build all the needed sub-libraries, and then meson will be able to find them all in a single shot.This PR fixes #11773 and supersedes #11798