New kwargs for gdbus-codegen: sources #3412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirbheek
changed the title
nirbheek
force-pushed
the
nirbheek/gdbus-codegen-sources
branch
from
df22879
to
0b4e542
Compare
|
Why the depend_files? Shouldn't gdbus-codegen write a dep file with exact dependency information? |
|
I looked at it again, and in the case of glib, that kwarg is also needed because we don't re-run targets that use gdbus-codegen when some of the internal python files it uses are changed. I wonder how we can fix this in a generic way. |
nirbheek
force-pushed
the
nirbheek/gdbus-codegen-sources
branch
3 times, most recently
from
1ecd380
to
9d9061c
Compare
mesonbuild/modules/gnome.py
Outdated
| @@ -869,12 +869,13 @@ def _unpack_args(arg, kwarg_name, kwargs, expend_file_state=None): | |||
| return [] | |||
|
|
|||
| @permittedKwargs({'interface_prefix', 'namespace', 'object_manager', 'build_by_default', | |||
| 'annotations', 'docbook', 'install_header', 'install_dir'}) | |||
| 'annotations', 'docbook', 'install_header', 'install_dir', 'sources'}) | |||
| 'annotations', 'docbook', 'install', 'install_header'}) | |||
There was a problem hiding this comment.
[Flake8]
[E113] unexpected indentation
mesonbuild/modules/gnome.py
Outdated
| @@ -869,12 +869,13 @@ def _unpack_args(arg, kwarg_name, kwargs, expend_file_state=None): | |||
| return [] | |||
|
|
|||
| @permittedKwargs({'interface_prefix', 'namespace', 'object_manager', 'build_by_default', | |||
| 'annotations', 'docbook', 'install_header', 'install_dir'}) | |||
| 'annotations', 'docbook', 'install_header', 'install_dir', 'sources'}) | |||
| 'annotations', 'docbook', 'install', 'install_header'}) | |||
There was a problem hiding this comment.
[Flake8]
[E111] indentation is not a multiple of four
mesonbuild/modules/gnome.py
Outdated
| @@ -869,12 +869,13 @@ def _unpack_args(arg, kwarg_name, kwargs, expend_file_state=None): | |||
| return [] | |||
|
|
|||
| @permittedKwargs({'interface_prefix', 'namespace', 'object_manager', 'build_by_default', | |||
| 'annotations', 'docbook', 'install_header', 'install_dir'}) | |||
| 'annotations', 'docbook', 'install_header', 'install_dir', 'sources'}) | |||
| 'annotations', 'docbook', 'install', 'install_header'}) | |||
There was a problem hiding this comment.
[Flake8]
[E999] IndentationError: unexpected indent
It accepts multiple XML files, not just one. For example, glib uses it that way.
nirbheek
force-pushed
the
nirbheek/gdbus-codegen-sources
branch
from
9d9061c
to
45f6a83
Compare
nirbheek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sources:accepts multiple XML files, not just one. For example, glib uses it that way.Also need
depend_files:.This is required for having glib use the GNOME module once #3218 is merged.