-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New kwargs for gdbus-codegen: sources #3412
Conversation
df22879
to
0b4e542
Compare
Why the depend_files? Shouldn't gdbus-codegen write a dep file with exact dependency information? |
I looked at it again, and in the case of glib, that kwarg is also needed because we don't re-run targets that use gdbus-codegen when some of the internal python files it uses are changed. I wonder how we can fix this in a generic way. |
1ecd380
to
9d9061c
Compare
mesonbuild/modules/gnome.py
Outdated
@@ -869,12 +869,13 @@ def _unpack_args(arg, kwarg_name, kwargs, expend_file_state=None): | |||
return [] | |||
|
|||
@permittedKwargs({'interface_prefix', 'namespace', 'object_manager', 'build_by_default', | |||
'annotations', 'docbook', 'install_header', 'install_dir'}) | |||
'annotations', 'docbook', 'install_header', 'install_dir', 'sources'}) | |||
'annotations', 'docbook', 'install', 'install_header'}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Flake8]
[E113] unexpected indentation
mesonbuild/modules/gnome.py
Outdated
@@ -869,12 +869,13 @@ def _unpack_args(arg, kwarg_name, kwargs, expend_file_state=None): | |||
return [] | |||
|
|||
@permittedKwargs({'interface_prefix', 'namespace', 'object_manager', 'build_by_default', | |||
'annotations', 'docbook', 'install_header', 'install_dir'}) | |||
'annotations', 'docbook', 'install_header', 'install_dir', 'sources'}) | |||
'annotations', 'docbook', 'install', 'install_header'}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Flake8]
[E111] indentation is not a multiple of four
mesonbuild/modules/gnome.py
Outdated
@@ -869,12 +869,13 @@ def _unpack_args(arg, kwarg_name, kwargs, expend_file_state=None): | |||
return [] | |||
|
|||
@permittedKwargs({'interface_prefix', 'namespace', 'object_manager', 'build_by_default', | |||
'annotations', 'docbook', 'install_header', 'install_dir'}) | |||
'annotations', 'docbook', 'install_header', 'install_dir', 'sources'}) | |||
'annotations', 'docbook', 'install', 'install_header'}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Flake8]
[E999] IndentationError: unexpected indent
It accepts multiple XML files, not just one. For example, glib uses it that way.
9d9061c
to
45f6a83
Compare
sources:
accepts multiple XML files, not just one. For example, glib uses it that way.Also need
depend_files:
.This is required for having glib use the GNOME module once #3218 is merged.