add markJobSuccessful api call #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Dependencies in job scheduler to implement. Pull out logic for getting new job config with incremented success into method. Add unit tests
|
Looks good, thanks! |
| * Method: __PUT__ | ||
| * Query string parameters: `arguments` - jobname to be marked success | ||
| * Example: `curl -L -X PUT chronos-node:8080/scheduler/job/success/request_event_counter_hourly` | ||
| * Response: boolean (true or false depending on success of request) |
There was a problem hiding this comment.
The response is actually a string formatted with: "marked job %s as successful: %b"
It is always 200 OK even if success is false, which basically forces clients of the API to parse the returned string. Returning JSON would simplify parsing, using a different status code would be even better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add logic in job scheduler to trigger dependencies and Pull out logic for getting new job config with incremented success into method. Add unit tests