Allow Chronos jobs to override taskInfo data #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
- Add 'taskInfoData' field to Chronos jobs - If specified on a job, this data is placed in the data field of the taskInfo object, which is passed to the mesos executor. - If not specified, then default Chronos task data is used (as per previous behaviour).
|
James and I discussed and went through reviews and this is looking good. @jamesmulcahy, can you please rebase? Any objections or comments? If there are no objections, I will go ahead and merge. |
jamesmulcahy
force-pushed
the
executor-data
branch
from
9e6ba30
to
c2ae724
Compare
elingg
added a commit
that referenced
this pull request
Mar 3, 2016
Allow Chronos jobs to override taskInfo data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
data field of the taskInfo object, which is passed
to the mesos executor.
is used (as per previous behaviour).