Fix mesos.Credential.secret type mismatch #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An Jan.16 2016 update of mesos/mesos-go changes type of
mesos.Credential.secret from bytes to string.
mesos/mesos-go@7870a46#diff-8b984a6759078d3bd0e4a27e90ab541dR1239
This results a type mismatch at scheduler/init.go:50. Error
message below
cannot use secret (type []byte) as type *string in field value
This patch fixes it by converting `secret` from []byte to string
before passing it to mesos.Credential.
|
Close it for now. We need some internal review before publishing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An Jan.16 2016 update of mesos/mesos-go changes type of
mesos.Credential.secret from bytes to string.
This results a type mismatch at scheduler/init.go:50. Error
message below
This patch fixes it by converting
secretfrom []byte to stringbefore passing it to mesos.Credential.