Restore option for cluster type #324
Conversation
|
Can one of the admins verify this patch? |
|
@mesosphere-ci retest this please |
1 similar comment
|
@mesosphere-ci retest this please |
|
@mesosphere-ci retest this please |
1 similar comment
|
@mesosphere-ci retest this please |
|
@mesosphere-ci retest this please |
| final String destinationFile = cfDir.getAbsolutePath() + fileKey.substring(fileKey.lastIndexOf("/")); | ||
| downloadFile(tx, bucketName, fileKey, destinationFile); | ||
| LOGGER.info("Keyspace {}, Column Family {}, FileKey {}, destination {}", keyspace, columnFamily, fileKey, destinationFile); | ||
| if (ctx.getRestoreType().equals("new")) { |
There was a problem hiding this comment.
Nit: Use Objects.equals().
There was a problem hiding this comment.
will fix in next PR of restore schema.
| @@ -79,6 +82,16 @@ public void setAzureKey(String azureKey) { | |||
| this.azureKey = azureKey; | |||
| } | |||
|
|
|||
| public String getRestoreType() { | |||
| if (restoreType != null && !restoreType.isEmpty()) { | |||
There was a problem hiding this comment.
Nit: Maybe use StringUtils.isNotBlank(restoreType)
There was a problem hiding this comment.
will fix in next PR of restore schema.
| @@ -108,6 +122,10 @@ private boolean isValidAzureRequest() { | |||
| return azureAccount != null && azureKey != null && externalLocation.startsWith("azure:"); | |||
| } | |||
|
|
|||
| private boolean isValidRestoreType() { | |||
| return restoreType == null || restoreType.isEmpty() ? true: restoreType.matches("existing|new"); | |||
There was a problem hiding this comment.
Why is a null OR empty restoreType valid ?
There was a problem hiding this comment.
BackupRestoreRequest object is used for backup and restore request, and for backup request, restoretype can be set null or empty.
For restore, added a new option to restore on existing cluster with same token range or a completely new cluster bootstrapped from scratch. For same cluster, use nodetool refresh to restore data and for new cluster use sstableloader. Difference is due to the significant performance disparity.