Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use INCOMING_WEBHOOK for slack hook #2822

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

takirala
Copy link
Contributor

set the type explicitly for richer formatting

This should be the final fix after #2819

What problem does this PR solve?:

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

set the type explicitly for richer formatting
@takirala takirala self-assigned this Nov 14, 2024
@takirala takirala requested a review from a team November 14, 2024 00:18
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 14, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11828166629

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.703%

Totals Coverage Status
Change from base Build 11825055115: 0.0%
Covered Lines: 167
Relevant Lines: 323

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants