Merge pull request #95 from messagebird/add-shorturls-param-to-message

Add support for the shortenUrls parameter in message
messagebird · Oct 23, 2020 · 69570d3 · 69570d3
2 parents cc69128 + 16dfc01
commit 69570d3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/sms/message.go b/sms/message.go
@@ -14,7 +14,7 @@ import (
 // Is only used when a binary or premium message is sent.
 type TypeDetails map[string]interface{}
 
-// Message struct represents a message at MessageBird.com
+// Message struct represents a message at messagebird.com.
 type Message struct {
 	ID                string
 	HRef              string
@@ -54,6 +54,7 @@ type Params struct {
 	DataCoding        string
 	ReportURL         string
 	ScheduledDatetime time.Time
+	ShortenURLs       bool
 }
 
 // ListParams provides additional message list options.
@@ -79,6 +80,7 @@ type messageRequest struct {
 	MClass            int         `json:"mclass,omitempty"`
 	ReportURL         string      `json:"reportUrl,omitempty"`
 	ScheduledDatetime string      `json:"scheduledDatetime,omitempty"`
+	ShortenURLs       bool        `json:"shortenUrls"`
 }
 
 // path represents the path to the Message resource.
@@ -94,7 +96,7 @@ func Read(c *messagebird.Client, id string) (*Message, error) {
 	return message, nil
 }
 
-// Cancel sending Scheduled Sms
+// Cancel sending Scheduled Sms.
 func Delete(c *messagebird.Client, id string) (*Message, error) {
 	message := &Message{}
 	if err := c.Request(message, http.MethodDelete, path+"/"+id, nil); err != nil {
@@ -172,6 +174,7 @@ func requestDataForMessage(originator string, recipients []string, body string,
 	request.TypeDetails = params.TypeDetails
 	request.DataCoding = params.DataCoding
 	request.ReportURL = params.ReportURL
+	request.ShortenURLs = params.ShortenURLs
 
 	return request, nil
 }

diff --git a/sms/message_test.go b/sms/message_test.go
@@ -350,6 +350,7 @@ func TestRequestDataForMessage(t *testing.T) {
 		TypeDetails:       nil,
 		DataCoding:        "unicode",
 		ScheduledDatetime: currentTime,
+		ShortenURLs:       true,
 	}
 
 	request, err := requestDataForMessage("MSGBIRD", []string{"31612345678"}, "MyBody", messageParams)
@@ -387,5 +388,7 @@ func TestRequestDataForMessage(t *testing.T) {
 	if request.ScheduledDatetime != messageParams.ScheduledDatetime.Format(time.RFC3339) {
 		t.Errorf("Unexepcted scheduled date time: %s, expected: %s", request.ScheduledDatetime, messageParams.ScheduledDatetime.Format(time.RFC3339))
 	}
-
+	if !request.ShortenURLs {
+		t.Errorf("Unexpected shorten URL flag: %v, expected: true", request.ShortenURLs)
+	}
 }