Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added read, list, search methods for numbers API #67

Merged
merged 15 commits into from
Aug 15, 2019

Conversation

ghost
Copy link

@ghost ghost commented Aug 8, 2019

No description provided.

Copy link
Contributor

@epels epels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Fredy, thanks for the PR! I have left some comments

number/number.go Outdated Show resolved Hide resolved
number/number.go Outdated Show resolved Hide resolved
number/number.go Outdated Show resolved Hide resolved
number/number.go Outdated Show resolved Hide resolved
number/number.go Outdated Show resolved Hide resolved
number/number_test.go Outdated Show resolved Hide resolved
number/number.go Outdated Show resolved Hide resolved
number/number.go Outdated Show resolved Hide resolved
number/number.go Outdated Show resolved Hide resolved
number/number.go Outdated Show resolved Hide resolved
Copy link
Contributor

@epels epels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good in general! Left a few comments.

Some more general remarks:

  • godoc comments are typically full sentences ending in a period.
  • It appears not all code has been run through gofmt, and most files have no trailing new line at EOF. It's probably worthwhile setting up your editors to enforce these.
  • Looks like you default to Fatalf in all tests, but in many cases test output can be more useful when used with Errorf. Personally, I only use Fatalf when it makes no sense to continue the rest of the test. E.g. here, it is still useful to assert the query string - even if the response object's country code doesn't match.

number/number.go Outdated Show resolved Hide resolved
number/number.go Outdated Show resolved Hide resolved
number/number.go Outdated Show resolved Hide resolved
number/number_test.go Show resolved Hide resolved
number/number_test.go Outdated Show resolved Hide resolved
@epels epels merged commit c9ccdcf into messagebird:master Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants