Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't insert -- separator when forwarding arguments #11

Closed
wants to merge 1 commit into from

Conversation

cpick
Copy link

@cpick cpick commented Apr 13, 2024

This allows arguments to be passed to the underlying cargo sub-command (by manually using a single --) or to the executed binary (by manually using two --s).

For example, the following now works:

cargo-zigbuild test -- -- --nocapture

Fixes rust-cross/cargo-zigbuild#240

This allows arguments to be passed to the underlying `cargo` sub-command (by manually using a single `--`) or to the executed binary (by manually using two `--`s).

For example, the following now works:
```sh
cargo-zigbuild test -- -- --nocapture
```

Fixes rust-cross/cargo-zigbuild#240
@cpick
Copy link
Author

cpick commented Apr 13, 2024

This certainly fixes my use case (it fixes the test command's arguments like --nocapture) , but prevents cargo-zigbuild from being a drop-in replacement to cargo (since users need to add another --).

I'm not sure what the intended behavior is.

@cpick
Copy link
Author

cpick commented Apr 13, 2024

I believe #12 fixes the issue while preserving cargo-zigbuilds intended, drop-in-replacement behavior.

@cpick cpick closed this Apr 13, 2024
@cpick cpick deleted the rm-arg-separator branch April 17, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo-zigbuild test doesn't pass arguments through properly
1 participant