Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix combined tooltip for charts" #18227

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Revert "Fix combined tooltip for charts" #18227

merged 1 commit into from
Oct 5, 2021

Conversation

ranquild
Copy link
Contributor

@ranquild ranquild commented Oct 4, 2021

Reverts #17946

@ranquild ranquild self-assigned this Oct 4, 2021
@ranquild ranquild requested review from a team and flamber October 4, 2021 19:00
@codecov
Copy link

codecov bot commented Oct 4, 2021 •
edited
Loading

Codecov Report

Merging #18227 (9558d06) into master (38faad6) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18227      +/-   ##
==========================================
- Coverage   63.93%   63.93%   -0.01%     
==========================================
  Files        1657     1657              
  Lines       68022    68021       -1     
  Branches     7394     7394              
==========================================
- Hits        43493    43492       -1     
  Misses      21298    21298              
  Partials     3231     3231
Flag Coverage Δ
front-end 40.81% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/metabase/visualizations/lib/apply_tooltips.js 77.55% <100.00%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38faad6...9558d06. Read the comment docs.

@ranquild ranquild added the backport Automatically create PR on current release branch on merge label Oct 5, 2021
@ranquild ranquild merged commit 7e201ea into master Oct 5, 2021
@ranquild ranquild deleted the revert-17946-16249-combined-series-tooltip branch October 5, 2021 10:03
@ranquild
Copy link
Contributor Author

ranquild commented Oct 5, 2021

@metabase-bot backport release-x.41.x

github-actions bot pushed a commit that referenced this pull request Oct 5, 2021
@ranquild
Revert "Fix combined tooltip for charts (#17946)" (#18227)
146f148
@github-actions github-actions bot mentioned this pull request Oct 5, 2021
Merged
@ranquild ranquild mentioned this pull request Oct 5, 2021
Closed
ranquild pushed a commit that referenced this pull request Oct 5, 2021
@github-actions
Revert "Fix combined tooltip for charts (#17946)" (#18227) (#18244)
e227274
@rlotun rlotun mentioned this pull request Oct 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulyk kulyk kulyk approved these changes

@flamber flamber Awaiting requested review from flamber

Assignees

@ranquild ranquild

Labels
backport Automatically create PR on current release branch on merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ranquild @kulyk