-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StateManager: Pass intermediates using normalized values, rename coerce to normalize #298
Conversation
I used functools.wrap, and I think I'm using it the right way. Requires this small change to artifax: curvewise-forks/artifax#3 I am now getting this error:
@paulmelnikow I wanted to discuss it with you, because I fell like this is close, but I don't fully understand the error. |
Somehow we are ending up in here: https://github.com/metabolize/werkit/blob/main/werkit/compute/graph/testing_examples.py#L75 |
@paulmelnikow This is ready for re-review. |
@paulmelnikow I'm having trouble understanding why |
Is it because it needs the artifax change? |
@paulmelnikow This is ready for re-review. |
Let's update the main branch in our fork from the upstream repo, and then PR the change in artifax onto that and re-tag. Also let's give this a commit message that describes what's changing. Apart from that this looks great. |
No description provided.