Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not trim control field values in MARCXML handler. #440

Closed
blackwinter opened this issue Feb 15, 2022 · 0 comments · Fixed by #441
Closed

Do not trim control field values in MARCXML handler. #440

blackwinter opened this issue Feb 15, 2022 · 0 comments · Fixed by #441
Assignees
@blackwinter
Labels
Bug

Comments

@blackwinter
Copy link
Member

Originally introduced in 5bdcd5d, this breaks positional access (<substring>) to control field data elements.

For fixed-length fields with various kinds of coded information, specific data elements are positionally defined.

— MARC 21 Bibliographic - Control Fields

Related to #233.
@blackwinter blackwinter self-assigned this Feb 15, 2022
blackwinter added a commit that referenced this issue Feb 15, 2022
@blackwinter
Do not trim control field values in MARCXML handler. (#440)
df6a862 
Breaks positional access to control field data elements.

https://www.loc.gov/marc/bibliographic/bd00x.html
@blackwinter blackwinter mentioned this issue Feb 15, 2022
Merged
@dr0i dr0i added the Bug label Feb 17, 2022
blackwinter added a commit to hbz/limetrans that referenced this issue Feb 25, 2022
@blackwinter
Temporarily set metafacture dependency to master-SNAPSHOT.
3b4c65b 
metafacture/metafacture-core#440
blackwinter added a commit to hbz/limetrans that referenced this issue Mar 29, 2022
@blackwinter
Temporarily set metafacture dependency to master-SNAPSHOT.
72432a6 
metafacture/metafacture-core#440
blackwinter added a commit to hbz/limetrans that referenced this issue Apr 26, 2022
@blackwinter
Temporarily set metafacture dependency to master-SNAPSHOT.
3330efd 
metafacture/metafacture-core#440
blackwinter added a commit to hbz/limetrans that referenced this issue May 4, 2022
@blackwinter
Temporarily set metafacture dependency to master-SNAPSHOT.
1e0486b 
metafacture/metafacture-core#440
blackwinter added a commit to hbz/limetrans that referenced this issue May 20, 2022
@blackwinter
Upgrade metafacture-core dependency to 5.3.2.
9ef3c88 
metafacture/metafacture-core#440
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blackwinter blackwinter

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not trim control field values in MARCXML handler. metafacture/metafacture-core
2 participants
@blackwinter @dr0i