Fix broken marc21 encoder #282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 23, 2018 12:48
Add test that checks, if the Marc21 Encoder produces an output that may be processed by the Marc21 Decoder.
Verify that the current entity is a field entity before calling endDataField.
Fixes malformed test record.
Adds a test that checks, if a pass through a Marc21-Decoder-Encoder stream alters the processed record.
…level Places encoding level, cataloging form and multipart level in position 17, 18 and 19.
ghost
changed the title
|
Thanks for you pull request. You fixes relate to issues #278 and #284. I'd like to merge your fix for #278. For issue #284, however, I implemented a different fix (in 46dee86) which ensured that the system characters are written to the correct position. This avoids having to add setters for MARC specific fields to the generic ISO-2709 record implementation. Can you please update the pull request to only contain the commits relevant for issue #278. Thank you! |
Reverts the state of the branch to changes that are only relevant to issue #278.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the incompatibility of the Marc21 Decoder and Encoder.
Issue
Fixes