Add how to ignore namespace in MARC XML Handler #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr0i
force-pushed
the
552-addHowToIgnoreNamespacesInMarcXmlHandler
branch
from
2ad7577
to
a0cd80c
Compare
fsteeg
reviewed
Jul 15, 2024
metafacture-biblio/src/main/java/org/metafacture/biblio/marc21/MarcXmlHandler.java
Show resolved
Hide resolved
dr0i
force-pushed
the
552-addHowToIgnoreNamespacesInMarcXmlHandler
branch
from
a0cd80c
to
5616ae8
Compare
The MARC21 namespace is checked by default. Sometimes there is MARC21 data without the proper namespace or none namespace at all. To make the handler run in such cases the namespace must be explicitly set as parameter to match the namespace used in the data. The @description describes how to set an empty namespace if the namespace is missing. Ignoring the namepace at all can be done only via JAVA-API by setting it to null.
dr0i
force-pushed
the
552-addHowToIgnoreNamespacesInMarcXmlHandler
branch
from
5616ae8
to
f81abb6
Compare
fsteeg
approved these changes
Jul 16, 2024
metafacture-biblio/src/main/java/org/metafacture/biblio/marc21/MarcXmlHandler.java
Outdated
Show resolved
Hide resolved
…/MarcXmlHandler.java Co-authored-by: Fabian Steeg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #552.
The @description describes how to set the namespace
to nullas empty using the flux. The method description describes how to even set it tonullthus ignoring the namespace at all using the JAVA-API.