Improvements on finalize allocation function. #210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the sequence of the
finalize-allocation
endpoint handler:MachineUpdate
after theSwitchUpdate
SwitchUpdate
has a higher chance to run into concurrent modification errors (Failure to report reinstall by metal-hammer results in fresh install with wiped disks #207) and we don't want to leavereinstall
mode before the machine was put into the right VRFAllocation.Succeeded
gets set (Machine allocation succeeded flag never gets set #209) preventing metal-core to re-run the hammer after finalizing the allocation, probably also having an impact on gardener-extension-provider-metal firewall reconciliationCloses #209.