Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only fetch required ips per switch describe instead of all #563

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

majst01
Copy link
Contributor

@majst01 majst01 commented Aug 16, 2024

During switch describe, which is called from every metal-core every 20 sec, all ips are listed and later filtered by project.
This is a lot of useless data fetched.

This was also found during the dualstack implementation, test was not adopted yet.

TODO:

  • write integration test with real rethinkdb in place which proves correctness

})
})

ips := make([]metal.IP, 0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ips := make([]metal.IP, 0)
ips := metal.IPs{}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants