Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Refactor handling the provisioner's ready status #1433

Merged
merged 1 commit into from
Nov 21, 2023
Merged

🌱 Refactor handling the provisioner's ready status #1433

merged 1 commit into from
Nov 21, 2023

Conversation

dtantsur
Copy link
Member

@dtantsur dtantsur commented Nov 7, 2023

In preparation for the future microversion negotiation handling:

  1. Remove the unnecessary ironicDependenciesChecker abstraction.
    It probably made more sense when Inspector was used explicitly.
  2. Change tests to make Ready the default state (and NotReady
    an explicit override for the few tests that need it).

@dtantsur
Refactor handling the provisioner's ready status
c3426f3 
In preparation for the future microversion negotiation handling:
1) Remove the unnecessary ironicDependenciesChecker abstraction.
   It probably made more sense when Inspector was used explicitly.
2) Change tests to make Ready the default state (and NotReady
   an explicit override for the few tests that need it).
@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 7, 2023
@dtantsur
Copy link
Member Author

dtantsur commented Nov 7, 2023

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@dtantsur dtantsur mentioned this pull request Nov 7, 2023
Merged
@elfosardo
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2023
@honza
Copy link
Member

honza commented Nov 20, 2023

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: honza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2023
@metal3-io-bot
Copy link
Contributor

@dtantsur: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
gosec c3426f3 link unknown /test gosec
golint c3426f3 link unknown /test golint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@metal3-io-bot metal3-io-bot merged commit c3426f3 into metal3-io:main Nov 21, 2023
10 of 13 checks passed
@dtantsur dtantsur deleted the no-deps branch November 21, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dtantsur @elfosardo @honza @metal3-io-bot