-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Implement Detached/Status Annotation E2E Test #1434
🌱 Implement Detached/Status Annotation E2E Test #1434
Conversation
/metal3-bmo-e2e-test |
726800e
to
1cf455c
Compare
/metal3-bmo-e2e-test |
f6de6dd
to
24269c8
Compare
/metal3-bmo-e2e-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great job!
As discussed off-line, we could make turn some of this into generic functions, but I would say it is preferable to merge this first and then follow up with a refactor. Then we can also change other tests at the same time, e.g. to add a CreateSecret
function used by all of them.
24269c8
to
bac84bd
Compare
/metal3-bmo-e2e-test |
/test-centos-e2e-integration-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test-centos-e2e-integration-main |
/cc @kashifest @dtantsur |
Validate BMH status retention across delete & recreate with annotations.
bac84bd
to
587056e
Compare
/metal3-bmo-e2e-test |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Re-adding the lgtm as well since that went away for the comment change. |
What this PR does / why we need it:
Validate BMH status retention across delete & recreate with annotations.
Fixes #1368