-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add github workflow for e2e fixture tests #1437
🌱 Add github workflow for e2e fixture tests #1437
Conversation
e13dce3
to
99dd94a
Compare
99dd94a
to
89ef8e8
Compare
cf070b4
to
370de00
Compare
478c56e
to
ab9ee4b
Compare
ab9ee4b
to
fc20642
Compare
e4bff1d
to
b16908b
Compare
/metal3-bmo-e2e-test |
/test-centos-e2e-integration-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
91b0184
to
e71b1ae
Compare
/unhold |
e71b1ae
to
b7a3e37
Compare
/metal3-bmo-e2e-test |
/test-centos-e2e-integration-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Implement lightweight fixture-based tests to ensure CI platform flexibility.
b7a3e37
to
d76e42e
Compare
/metal3-bmo-e2e-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test-ubuntu-integration-main |
@@ -33,7 +33,7 @@ intervals: | |||
default/wait-registering: ["1m", "5s"] | |||
inspection/wait-registration-error: ["1m", "5s"] | |||
external-inspection/wait-available: ["20s", "1s"] | |||
default/wait-inspecting: ["2m", "10s"] | |||
default/wait-inspecting: ["2m", "2s"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason to change this in this PR ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using 10-second intervals means that it can miss the state, so I changed it to 2-seconds to make the test more robust.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right to ask because I now see that this is in the ironic config, but after trying it out I noticed some flakes here so that why this fix is in this PR even that it has nothing to do with fixture.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Implement lightweight fixture-based tests to ensure CI platform flexibility.
Fixes #1406