Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Don't munge timestamp in structured logs, again #1439

Merged

Commits on Nov 10, 2023

  1. Don't munge timestamp in structured logs, again

    Structured logging tools expect a POSIX timestamp.
    0a887a1 reverted to changing the
    timestamp formatting only in development log mode, after
    9ecf171 had explicitly and
    unconditionally set the format to ISO-8601.
    
    However, almost immediately after this,
    5bf0440 bumped the controller-runtime
    version from 0.13.1 to 0.14.5. In 0.14, the default zap options in
    controller-runtime changed to RFC3339 - which is the same as ISO-8601
    but even worse because subsecond precision (which can be very important
    to debugging) is lost as well.
    
    This change explicitly restores the original default.
    zaneb committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    4b8c581 View commit details
    Browse the repository at this point in the history